Skip to content

gdg charusat team 036 Fix: Add lazy loading to testimonial images in index.html#52

Open
Pratham3900 wants to merge 7 commits intokeploy:mainfrom
Pratham3900:fix-lazy-loading-testimonials
Open

gdg charusat team 036 Fix: Add lazy loading to testimonial images in index.html#52
Pratham3900 wants to merge 7 commits intokeploy:mainfrom
Pratham3900:fix-lazy-loading-testimonials

Conversation

@Pratham3900
Copy link
Copy Markdown

GDG CHARUSAT TEAM 036

Description

Fixed testimonial images in index.html that were loading eagerly on page load.
Added native loading="lazy" attribute to all testimonial <img> tags and updated alt attributes for better accessibility.

Fixes #51
Team ID: GDG CHARUSAT TEAM 036

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Opened index.html in the browser.
  • Verified that images load lazily using Chrome DevTools → Network tab → “Images” section.
  • Verified that page load speed improved and no images were broken.

Additional Context (Please include any Screenshots/gifs if relevant)

Before:

<img src="./images/testimonials/sanskriti.avif" alt="">
<img src="./images/testimonials/sukriti.avif" alt="">
<img src="./images/testimonials/neel.jpg" alt="">
<img src="./images/testimonials/harsh.avif" alt="">
<img src="./images/testimonials/arunima.avif" alt="">

After:

<img src="./images/testimonials/sanskriti.avif" alt="Sanskriti Gupta" loading="lazy">
<img src="./images/testimonials/sukriti.avif" alt="Sukriti Maurya" loading="lazy">
<img src="./images/testimonials/neel.jpg" alt="Neel Shah" loading="lazy">
<img src="./images/testimonials/harsh.avif" alt="Harsh Rastogi" loading="lazy">
<img src="./images/testimonials/arunima.avif" alt="Arunima Chaudhuri" loading="lazy">

Checklist:

 My code follows the style guidelines of this project

 I have performed a self-review of my own code

 I have commented my code, particularly in hard-to-understand areas

 I have made corresponding changes to the documentation

 My changes generate no new warnings

 I have added tests that prove my fix is effective or that my feature works

 New and existing unit tests pass locally with my changes

 Any dependent changes have been merged and published in downstream modules

 I have checked my code and corrected any misspellings

 I have tagged the reviewers in a comment below incase my pull request is ready for a review

 I have signed the commit message to agree to Developer Certificate of Origin (DCO) by adding "--signoff" to my git commit command

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congratulations 🎉 for opening your very first pull request in student-program

Signed-off-by: Pratham3900 <prathamdanawala@gmail.com>
Signed-off-by: pratham danawala <prathamdanawala@gmail.com>
Signed-off-by: Pratham3900 <prathamdanawala@gmail.com>
Signed-off-by: Pratham3900 <prathamdanawala@gmail.com>
Signed-off-by: Pratham3900 <prathamdanawala@gmail.com>
@Adityacode-hub
Copy link
Copy Markdown

Hi, I would like to work on this issue. Please assign it to me.

@Pratham3900
Copy link
Copy Markdown
Author

@amaan-bhati I COMPLETETED THIS ISSUE PLEASE REVIEW AND MERGE IT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature]: Add loading="lazy" to testimonial images for better performance

2 participants